-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update test harness with metadata assertions #1467 #289
feat: Update test harness with metadata assertions #1467 #289
Conversation
feec001
to
ff27af0
Compare
Signed-off-by: christian.lutnik <[email protected]>
@aepfli do you think it makes more sense to simply add metadata to the existing gherkin suite? We already have error flags there - we could add metadata to some of the existing flags and error flags, and them update the in-memory providers to support this. |
Signed-off-by: christian.lutnik <[email protected]>
I am not sure if integration into the existing suite is suitable. We could enhance the existing ones, with a description of what the purpose of those flags is. But generally i prefer a flagname which already tells me what i can expect from this flag. This also brings me to the next topic. As we are currently generating the data in each sdk on our own, it might be worth to add a json here with the testdata, which we load into the inmemory provider, wdt? |
Signed-off-by: christian.lutnik <[email protected]>
Most in-memory providers can't actually load JSON, so I'm not sure how valuable that would be. |
i would not load them automagically, but within the tests, we can load the json files, and provide the data as parameter to the inmemory provider. We would centralize the test flag data, and with new gherkin files, which only add new data for experimentation everything should work ootb.
|
Co-authored-by: Simon Schrottner <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Oh, so all implementations would write a simple function |
excactly, and this way we ensure, everyone gets the same data afterall |
Merging this at just 2 green checks because it's just some test data and doesn't represent any fundamental new features or changes. |
This PR
Adds gherkin test to verify that flag evaluations provide metadata
Related Issues
Part of #1467 (open-feature/flagd#1467)
Follow-up Tasks
Implement steps of the gherkin file in the repositories, and add test data according to the issue